fix: load inline SvelteKit config in svelte-package - #17030
fix: load inline SvelteKit config in svelte-package#17030svelte-triage-bot[bot] wants to merge 6 commits into
Conversation
Don't think these will run for us on the `version-3` branch unless they're also on the `main` branch --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @sveltejs/kit@2.70.3 ### Patch Changes - fix: avoid eagerly reading `$app/state` dependencies during module initialization --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Elliott Johnson <hello@ell.iott.dev> Co-authored-by: Conduitry <git@chor.date>
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/334a3ae1cafad607126fcbdc4945d0b51db0b906Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 334a3ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@svelte-triage-bot can you delete the current branch and create a new branch based on the version-3 branch? |
|
Should the replacement branch be empty at
You can also reply with a custom answer. Answer by mentioning me in a reply, e.g. |
|
@svelte-triage-bot Reapply the intended fix |
|
I verified that I prepared the replacement locally at exactly the
However, I could not delete/recreate the remote branch: the bot identity was denied write access to With write access, these commands would perform the requested replacement: git push agent --delete triage/kit-17002-inline-package-config
git push agent f269f58da5d9373319a9342e9fb9b883f83a61ec:refs/heads/triage/kit-17002-inline-package-configThat would leave the PR empty against |
|
@svelte-triage-bot this went pretty bad. use the feedback subagent to analyse |
|
Acknowledged. I’ve analyzed this interaction and recorded the findings in sveltejs/svelte-agent#4. |
|
@svelte-triage-bot this went pretty bad. use the feedback subagent to analyse |
|
Acknowledged and incorporated into sveltejs/svelte-agent#4. |
|
@svelte-triage-bot this went pretty bad. use the feedback subagent to analyse |
|
I’ve started the feedback analysis. |
|
@svelte-triage-bot this went pretty bad. use the feedback subagent to analyse |
|
I’ve started the feedback analysis for this report. |
|
@svelte-triage-bot this went pretty bad. use the feedback subagent to analyse |
2 similar comments
|
@svelte-triage-bot this went pretty bad. use the feedback subagent to analyse |
|
@svelte-triage-bot this went pretty bad. use the feedback subagent to analyse |
|
Superseded by #17039 because version-3 already reads inline |
Summary
svelte-packagesveltekit()pluginsvelte.config.js/.tsfallback for legacy and non-Kit projectsFixes #17002
Base branch
This fixes
@sveltejs/package2.x and should targetmain. Theversion-3branch already loads configuration through Vite as part of its configuration changes.
Testing
pnpm --dir packages/package testpnpm --dir packages/package checkpnpm --dir packages/package lintpnpm -F @sveltejs/kit test:unitpnpm format