chore: read manifest from one module instead of threading it through the server runtime - #16967
Merged
Conversation
…the server runtime
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/61e9ecbbd184796a0ecd17d5b81fecc27bf26bacOpen in |
|
teemingc
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serverkeeps the manifest in#manifestand passes it torespond, from where it travels through 16 parameter positions inruntime/server, down tohas_prerendered_pathandload_error_components. The same object is written toruntime/server/internal.jsbyset_manifestin theServerconstructor, and$app/server'sread,$app/paths'sresolveand theread_implementationbranch infetch.jsalready read it from there, sofetch.jsmixed the parameter and the module singleton in one function.The parameter is gone and every reader imports
manifestfrominternal.js, the same shape #16871 gaveoptions. TheServerconstructor argument and itsset_manifestcall stay. In dev that call runs per request, so a request in flight during a manifest regeneration now sees the regenerated manifest, whichreadandresolvealready did.Closes #16519.