Skip to content

chore: read manifest from one module instead of threading it through the server runtime - #16967

Merged
teemingc merged 2 commits into
version-3from
manifest-singleton
Aug 27, 2026
Merged

chore: read manifest from one module instead of threading it through the server runtime#16967
teemingc merged 2 commits into
version-3from
manifest-singleton

Conversation

@Nic-Polumeyv

Copy link
Copy Markdown
Contributor

Server keeps the manifest in #manifest and passes it to respond, from where it travels through 16 parameter positions in runtime/server, down to has_prerendered_path and load_error_components. The same object is written to runtime/server/internal.js by set_manifest in the Server constructor, and $app/server's read, $app/paths's resolve and the read_implementation branch in fetch.js already read it from there, so fetch.js mixed the parameter and the module singleton in one function.

The parameter is gone and every reader imports manifest from internal.js, the same shape #16871 gave options. The Server constructor argument and its set_manifest call stay. In dev that call runs per request, so a request in flight during a manifest regeneration now sees the regenerated manifest, which read and resolve already did.

Closes #16519.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Aug 27, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 61e9ecb:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/61e9ecbbd184796a0ecd17d5b81fecc27bf26bac

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16967

@changeset-bot

changeset-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 61e9ecb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

@teemingc
teemingc merged commit 95ee350 into version-3 Aug 27, 2026
37 of 39 checks passed
@teemingc
teemingc deleted the manifest-singleton branch August 27, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unify SSRState and RequestState

2 participants