Repository navigation
fix: vite plugin builds - #102
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
surimi | 451cbe0 | Commit Preview URL Branch Preview URL |
Oct 03 2026, 12:46 PM |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Regression tests are needed to verify that module hooks run without repeating lifecycle hooks.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Restricts Surimi’s evaluation server to host module-pipeline hooks, preventing shared plugin lifecycle state from being reset.
Changes:
- Isolates
resolveId,load, andtransformhooks. - Excludes Vite-internal plugins.
- Updates API and guide documentation.
| File | Description |
|---|---|
packages/vite-plugin-surimi/src/types.ts |
Clarifies plugin filtering behavior. |
packages/vite-plugin-surimi/src/runner.ts |
Isolates seeded plugin hooks. |
packages/vite-plugin-surimi/src/plugin.ts |
Collects and passes host plugins. |
packages/docs/src/pages/docs/guides/vite.mdx |
Documents hook restrictions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.