Updates to work with latest versions of Azure/azure-storage-ruby and thotbot/paperclip - #15
Open
kinkade wants to merge 1 commit into
Open
Updates to work with latest versions of Azure/azure-storage-ruby and thotbot/paperclip#15kinkade wants to merge 1 commit into
kinkade wants to merge 1 commit into
Conversation
documented in: https://github.com/Azure/azure-storage-ruby/blob/master/BreakingChanges.md The most notable is that the create_blob_block method was renamed to put_blob_block.
|
Please can this get merged? |
|
There is also a missing gemspec file here - kinkade@baa18e6 |
Contributor
|
Not having a gemspec file means you can't link to this repo and/or a branch tag from your bundler file. I.e.
Changes were done by @kinkade not me. Thanks goes to him. |
Author
|
That's exactly right, @dannytip That's why I added an extra branch just so that I could use it in my apps. For others reading this thread, add this to your Gemfile:
|
|
Ive been using your branch @kinkade thanks very much 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
azure-storage-ruby has a breaking change:
#create_blob_blockwas renamed to#put_blob_block.https://github.com/Azure/azure-storage-ruby/blob/master/BreakingChanges.md
Also it looks like paperclip has changed
Paperclip::Storage::AzureRegiontoPaperclip::Storage::Azure::Environment.The changes in this PR got my app back working again.