fix(billing): Use canonical PAYG allowances in public estimator (fixes #399) - #420
Open
stroland02 wants to merge 1 commit into
Open
fix(billing): Use canonical PAYG allowances in public estimator (fixes #399)#420stroland02 wants to merge 1 commit into
stroland02 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where the public PAYG estimator was overstating the estimated monthly bill. Previously, the estimator did not account for the included investigation credits and telemetry allowances. By updating \Pricing.tsx\ to import and utilize the canonical billing models from @superlog/billing, the calculator now correctly factors in these allowances before computing overage costs. A regression test has also been added to ensure the pricing estimator logic remains sound. Fixes #399.
Summary by cubic
The public PAYG estimator now uses canonical billing rates and allowances from
@superlog/billing, so estimates no longer overstate monthly costs. It correctly accounts for included investigation credits and telemetry before charging overages.PLANS,PAYG_RATES, andPAYG_PROMOTION_CREDITSfrom@superlog/billing.Written for commit 49bd827. Summary will update on new commits.