Repository navigation
fix: declare explicit annotation hints on send_feedback - #57
Merged
Merged
Conversation
The Agentback SDK registers send_feedback without destructiveHint. ChatGPT's plugin guidelines require readOnlyHint, destructiveHint and openWorldHint as explicit booleans on every tool, and the daily MCP scan holds tools that miss them. Set all hints after registration. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DuYf7tfmsW91uukAP5riQ4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by fatwang2 · project thread
Why
ChatGPT's plugin guidelines (developers.openai.com/plugins/plugin-guidelines, "Correct annotation") require
readOnlyHint,destructiveHintandopenWorldHintas explicit booleans on every tool. OpenAI scans our published plugin's MCP server daily and holds new tools that fail checks.send_feedbackcomes from the Agentback SDK (agentback@0.2.0), which registers it with onlyreadOnlyHint: false, openWorldHint: true, sodestructiveHintis missing.What
attachToMcp, update the registered tool's annotations toreadOnlyHint: false,destructiveHint: false(a report only adds a record),idempotentHint: false,openWorldHint: true.send_feedbackannotations.The longer-term fix is to set
destructiveHint: falsein the Agentback SDK itself; this keeps search1api-mcp correct regardless of SDK version.Testing
npm test: 51/51 pass.Generated by Claude Code