feat: bump OpenAPI spec to 3.2.0 - #1277
Open
grdsdev wants to merge 5 commits into
Open
Conversation
3.2 is a strict superset of 3.1 for our purposes; validated the generated docs against the official OAS 3.2 meta-schema.
Coverage Report for CI Build 30402221115Coverage decreased (-0.005%) to 80.405%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
Builds both apps, fetches their /documentation/json, and validates against the official OAS 3.2 meta-schema (@hyperjump/json-schema).
grdsdev
marked this pull request as ready for review
July 28, 2026 20:59
schema-base recursively validates Schema Objects against the OAS 3.2 dialect; schema alone only checks them as opaque objects.
OpenAPI 3.2 Schema Objects are pure JSON Schema 2020-12, which has no nullable keyword — it's silently ignored, so these fields were documented as non-nullable despite AJV still accepting null at runtime. Use type: [X, 'null'] instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/app.tsandsrc/admin-app.ts.src/app.test.ts/src/admin-app.test.ts.Test plan
npm run test:unitpasses (public/admin app suites green; one pre-existing flaky pprof timeout test unrelated to this change).static/api.json/static/api-admin.jsonvianpm run docs:export, confirmed"openapi":"3.2.0".@hyperjump/json-schema/openapi-3-2) — both valid.