Repository navigation
feat: add Spark REST eval suite - #482
Open
mattrossman wants to merge 19 commits into
Open
mattrossman wants to merge 19 commits into
mattrossman wants to merge 19 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
mattrossman
marked this pull request as ready for review
November 4, 2026 20:52
gregnr
approved these changes
Nov 4, 2026
Comment on lines
+523
to
+528
| await using session = disposable( | ||
| await exp.runtime.startSession({ | ||
| ...readSessionSeedArgs(ev), | ||
| hostname: agentRunsInSandbox ? '0.0.0.0' : undefined, | ||
| }) | ||
| ); |
Collaborator
Author
There was a problem hiding this comment.
Unrelated but after our call I cleaned up the EVAL.ts a bit to make the checks easier to see in one place and understand why 2 queries are involved
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Spark eval suite and a minimal sample scenario for adding due dates to a seeded task tracker.
Follow-up from #471 which was a larger attempt at adding MCP / CLI integration and adapting existing scenarios.
Demo
See sample trace from a local run.
How to use
PROMPT.md,EVAL.ts, and optional seededremote/project.sqlunderevals/spark/<id>/.SPARK_API_URLin.env(find it here), connect to Supabase WARP, then runpnpm eval:upload -- --suite spark.The expected workflow is to add a scenario, verify it fails, update Spark API, and verify the eval passes. The Spark team owns the suite, skill, and runtime so they can run that process self-serve.
Notes
Spark interface is explained to agent in a
/sparkskill derived from spark-server/API.md.Currently this can only run locally with WARP access. CI support will need Sandboxes to have WARP access.
You can find existing scenarios from our benchmark and regression suites in evals/, though these will need adaptation to make sense for Spark due to known incompatibilities (e.g. many rely on RLS during setup).
Closes AI-1399