Repository navigation
feat(workflow): require requested reviews before merge readiness - #7
Merged
Merged
Conversation
Summary Prepare Commit It 3.0.0 for user-approved worker succession independent of chat retention. Changes - Preserve assignment lineage, checkpoints and legacy worker records through approved takeover. - Define OPS delivery receipts and synchronized purpose and work-state labels. - Name conversations through supported client tools and preserve honest review ownership. - Align package documentation and prepare version 3.0.0 without publishing a release tag. Verification - 27 package and installer tests passed; shell syntax and v3.0.0 release checks passed. - Independent eight-scenario review completed; readiness and review ownership ambiguities corrected. - git diff --check passed.
Summary Separate implementation readiness from requested code review and merge readiness. Changes - Default to implementation-worker requests and code review in another conversation. - Permit self-review only under explicit user approval and preserve scoped resolver exceptions. - Add MERGE_READY alongside REVIEW_READY after current review and head/base/check validation. - Invalidate readiness when evidence changes and keep reviews inside implementation scope. Verification - 27 package tests, shell syntax, release metadata and skill validation passed. - Cross-reference and diff checks passed; historical records and version 3.0.0 are retained.
sungyongcho-ops
added
OPS
sungyongcho-ops
added
REVIEW_READY
Owner
sungyongcho-ops
marked this pull request as ready for review
September 7, 2026 21:00
Owner
Summary Include the current main after its predecessor squash merge. Changes Resolve only history-induced conflicts; retain the exact tested PR file tree. Verification Main tree matches predecessor 1eb3dc1. Result tree matches PR head efed932. Existing passing package and CI evidence remains applicable. git diff --cached --check passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ordinary workers now stop at REVIEW_READY after implementation and verification. A code review requires a request from the implementation worker and runs in another conversation/task, limited to the actual implementation scope. Self-review requires explicit user approval; an implementation worker cannot approve its own exception.
MERGE_READY is an additional label alongside REVIEW_READY after valid review and current head/base/check verification. It grants no merge authority and is removed when its evidence changes. Explicitly assigned commit-error/conflict resolvers may close named PRs, edit named issues and self-review only within their action grant; original ownership and published history remain intact.
Verification: 27 package tests, shell syntax, release/skill validation and diff checks passed. No automatic review or tag publication was performed. Version 3.0.0 remains unchanged with an Unreleased note.
This PR is stacked on the existing worker-succession PR to preserve its unmerged package changes.