Repository navigation
feat: read appended data sections - #9
Merged
Merged
Conversation
Signed-off-by: Michael-F-Bryan <michael.bryan@sunfishrobotics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ULog
Readercurrently refuses files withDATA_APPENDED, which preventsbuttctl logs inspectfrom reading PX4 logs containing appended hardfault data. The captured bench log ends part-way through aDpayload, then starts a completeMhardfault message at the advertised offset, so merely ignoring the incompatibility flag would consume the appended message header as missing payload bytes.This makes the streaming reader track its absolute byte position and treat each advertised offset as a section boundary. A header or payload interrupted by that boundary is discarded only up to the offset, then parsing resumes with the existing formats and subscriptions. Appended offsets are validated as present and strictly increasing; the public
io.ReaderAPI remains unchanged and does not require seeking.With this branch, the original 17.8 MB bench log decodes through
buttctl logs inspectas 290,037 records and includes the appendedhardfault_plainmulti-information group.