Repository navigation
Conversation
|
Hi @aalu-love, thank you so much for this PR, and sorry for the bad news. I checked it closely, and the core of it is solid:
Two PRs ended up implementing #36: this one and #45. Only one can merge, because they change the same lines. Yours came first, so this wasn't an easy call. I'm going with #45 because it's much closer to ready: it passes
So I'm closing this one. It's not about the effort or the idea. The core logic here is good. Part of the mix-up is on me. The repo has no rule for claiming issues, and this PR didn't link #36, so the issue page didn't show that anyone was working on it. I'll add a short note to CONTRIBUTING.md about claiming issues. Two tips for next time:
I'd love to have you back. #38 (prefid-ai, a typed ID generator for the Vercel AI SDK) is open, marked help wanted, and nobody has picked it up. If it interests you, leave a comment there and we can work out the scope together. Thanks again! |
Summary
.many(prefix, count)for standard and sortable ID generators.Benchmark
Generating 20,000 standard IDs in local measurements:
Results may vary depending on the runtime and machine.
Checklist
npm run verifypasses.IdGeneratorfunction compatibility is preserved.Note
Sortable batch generation currently calls the single-ID generator repeatedly. It preserves monotonic ordering but does not yet batch random-byte generation for sortable IDs.