Repository navigation
fix(ask): preserve multi-module findings when agents fail - #122
Merged
study8677 merged 1 commit intoOct 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a cross-module question reaches the map.md/agent.md path, failed readers
are silently discarded. If the Synthesizer then fails, only the first successful
reader's answer is returned. For example, auth, api, and db can all finish reading
source successfully, yet the caller receives only the auth findings.
This change retains every usable reader answer, with module attribution and
original references, when synthesis fails or returns blank output. A visible
notice explains that these findings have not been reconciled. Failed or blank
reader responses produce a separate Partial answer notice naming the missing
modules, and the synthesizer is told not to infer their behavior. Explicit
"(not relevant)" responses remain distinct from failures. The fallback does not
make another model call; no-result cases retain the existing legacy fallback.
Validation
blank output, irrelevant responses, grouped modules, and existing behavior.
Scope and limitations
This targets the API-based map.md/agent.md multi-reader path. It does not alter
host-runner behavior, routing, retry policy, provider configuration, or public
CLI/MCP schemas. The fallback preserves findings rather than reconciling their
meaning, and may be longer than a normal synthesized answer. The tests exercise
orchestration offline; no paid-provider quality benchmark was run.