Skip to content

issue-34: add replace_empty_with_zero parameter for Cloudwatch metrics - #35

Open
Mortinke wants to merge 2 commits into
structurely:masterfrom
Mortinke:issue-34
Open

issue-34: add replace_empty_with_zero parameter for Cloudwatch metrics#35
Mortinke wants to merge 2 commits into
structurely:masterfrom
Mortinke:issue-34

Conversation

@Mortinke

Copy link
Copy Markdown
Contributor

No description provided.

@epwalsh

epwalsh commented Sep 30, 2019

Copy link
Copy Markdown
Member

@Mortinke thanks for this! This looks like a reasonable solution. I'm wondering though if it would be better to make it more general and have something like a default parameter instead of the replace_empty_with_zeros parameter.

@Mortinke

Mortinke commented Oct 8, 2019

Copy link
Copy Markdown
Contributor Author

@epwalsh: sorry, I missed your comment. I am on vacation with bad internet connection until 01.11. Then I'll take a look at it again.

@Mortinke

Copy link
Copy Markdown
Contributor Author

@epwalsh: Unfortunately I didn't make it earlier - other priorities in other projects :(
Can you look over the PR again? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants