Skip to content

feat(sdm): support priorityClassName on the relay and proxy Pods #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
satdeveloping wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(sdm): support priorityClassName on the relay and proxy Pods #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d697bd4
feat(sdm-relay): support priorityClassName on the relay Pod
satdeveloping Aug 18, 2026
c62ea8b
feat(sdm-proxy): support priorityClassName on the proxy Pod
satdeveloping Aug 19, 2026
66429ca
Merge branch 'main' into feat/sdm-relay-priorityclassname
kellenanker7 Sep 9, 2026
5413285
Merge branch 'main' into feat/sdm-relay-priorityclassname
kellenanker7 Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deployments/sdm-proxy/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: sdm-proxy
kubeVersion: ">= 1.16.0-0"
version: 2.7.7
version: 2.8.0
description: StrongDM Proxy
type: application
icon: https://raw.githubusercontent.com/strongdm/charts/main/sdm_icon.png
Expand Down
3 changes: 3 additions & 0 deletions deployments/sdm-proxy/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ spec:
serviceAccountName: {{ include "strongdm.serviceAccountName" . }}
{{- end }}
terminationGracePeriodSeconds: 10
{{- with .Values.strongdm.deployment.priorityClassName }}

@kellenanker7 kellenanker7 Sep 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the nit, but one last request for consistency with the other fields.

could you make these simply:

priorityClassName: {{ .Values.strongdm.deployment.priorityClassName }}

the default "" is valid if applied server-side 👍

priorityClassName: {{ . }}
{{- end }}
nodeSelector:
{{- with .Values.strongdm.deployment.nodeSelector }}
{{- toYaml . | nindent 8 }}
Expand Down
4 changes: 4 additions & 0 deletions deployments/sdm-proxy/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,10 @@
}
}
}
},
"priorityClassName": {
"description": "PriorityClass name for the Pod. Empty (the default) leaves it unset, so the Pod schedules at the cluster's global-default priority.",
"type": "string"
}
}
},
Expand Down
2 changes: 2 additions & 0 deletions deployments/sdm-proxy/values.test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,5 @@ strongdm:
baz: false
rbac:
create: true
deployment:
priorityClassName: system-cluster-critical
1 change: 1 addition & 0 deletions deployments/sdm-proxy/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ strongdm:
replicaCount: 2 # @schema description: Number of Pods to run in the deployment.
nodeSelector: {} # @schema description: Pod node selectors.
tolerations: [] # @schema description: Pod node tolerations.
priorityClassName: "" # @schema description: PriorityClass name for the Pod. Empty (the default) leaves it unset, so the Pod schedules at the cluster's global-default priority.
topologySpreadConstraints: # @schema description: Pod spread constraints. Keys in this map are topology keys. See https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/ for more info.
kubernetes.io/hostname:
maxSkew: 1
Expand Down
2 changes: 1 addition & 1 deletion deployments/sdm-relay/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: sdm-relay
kubeVersion: ">= 1.16.0-0"
version: 2.6.5
version: 2.7.0
description: StrongDM Relay
type: application
icon: https://raw.githubusercontent.com/strongdm/charts/main/sdm_icon.png
Expand Down
3 changes: 3 additions & 0 deletions deployments/sdm-relay/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ spec:
serviceAccountName: {{ include "strongdm.serviceAccountName" . }}
{{- end }}
terminationGracePeriodSeconds: 10
{{- with .Values.strongdm.deployment.priorityClassName }}
priorityClassName: {{ . }}

@kellenanker7 kellenanker7 Sep 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as the other comment!

{{- end }}
nodeSelector:
{{- with .Values.strongdm.deployment.nodeSelector }}
{{- toYaml . | nindent 8 }}
Expand Down
4 changes: 4 additions & 0 deletions deployments/sdm-relay/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,10 @@
"tolerations": {
"description": "Pod node tolerations.",
"type": "array"
},
"priorityClassName": {
"description": "PriorityClass name for the Pod. Empty (the default) leaves it unset, so the Pod schedules at the cluster's global-default priority.",
"type": "string"
}
}
},
Expand Down
2 changes: 2 additions & 0 deletions deployments/sdm-relay/values.test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,5 @@ strongdm:
baz: false
rbac:
create: true
deployment:
priorityClassName: system-cluster-critical
1 change: 1 addition & 0 deletions deployments/sdm-relay/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ strongdm:
labels: {} # @schema description: Map of labels to add to the Deployment.
nodeSelector: {} # @schema description: Pod node selectors.
tolerations: [] # @schema description: Pod node tolerations.
priorityClassName: "" # @schema description: PriorityClass name for the Pod. Empty (the default) leaves it unset, so the Pod schedules at the cluster's global-default priority.

pod: # @schema description: Pod configuration.
annotations: {} # @schema description: Map of annotations to add to Pods.
Expand Down