Repository navigation
CI: run only quick checks on GitHub, and the builds on the local computer - #38
Merged
Merged
Conversation
This commit changes only the format. CI checks the format from now on.
The changes keep the behaviour. Most changes come from cargo clippy --fix. Two functions with many arguments get an allow attribute. CI checks clippy from now on.
A pull request runs one Linux job. The job checks the format, runs clippy and runs the tests. CI ran for each push and again for the pull request. Now it runs for the pull request and for main only. The Windows and macOS jobs run cargo check after a merge to main. They do not build a release. The firmware workflow builds one image after a merge to main. scripts/check.sh runs the same checks and the two firmware builds on the local computer. The pre-push hook in .githooks runs the script.
A dated rule in AGENTS.md asks for a local build after each merge to main. GitHub Actions runs only quick checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub now runs only quick checks. The builds run on the local computer.
Changes
ci.ymlruns for a pull request and for a push tomain. It ran for each push to each branch and again for the pull request, so each commit ran two times.cargo fmt, andrustfmtforesp32/), runscargo clippy -- -D warningsand runscargo test.cargo checkafter a merge tomainor on a manual start. They do not build a release.release.ymlbuilds all targets from a tag, as before.esp32-ci.ymlbuilds one firmware image after a merge tomainor on a manual start. It does not run for a pull request. The workflow has nodmxbuild and no artifact upload now.concurrency). Onlymainwrites the Rust cache.docs/only does not startci.yml.scripts/check.shruns the checks of CI on the local computer. When the branch changesesp32/,crates/orwebui/, it also builds the firmware with and withoutdmx. On an M-series Mac, a full run with the firmware takes about 4 minutes..githooks/pre-pushruns the script. Enable it once for each clone:git config core.hooksPath .githooks.rustfmt. One commit fixes the clippy warnings without a change in behaviour. An open branch can get conflicts on the formatted lines. Rebase it, then runcargo fmt --all.Runner time for each commit of a pull request
ci.ymlesp32-ci.ymlTest
sh scripts/check.sh --esp32passes on the local computer: format, clippy, 240 tests, and the firmware with and withoutdmx.actionlintreports no error for the two workflow files.mainhas no branch protection, so the renamed and removed checks block no pull request.