Repository navigation
Show a message when no player is online, and a spinner for the update check - #36
Merged
Merged
Conversation
… check When the page has no player and no Ableton Link source (no_devices), the Master panel shows a message. It does not show the empty BPM, beat and phrase fields. When you click "Check for update", the page shows a spinner and the text "checking…". The box sends no status during the check. Thus the page stops the spinner at the first status that comes 1.5 s after the click, or at an error reply.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
no_devices), the Master panel shows a message. It does not show the empty BPM, beat and phrase fields.Test
cargo test --lockedpasses.cargo build --release --lockedinesp32/passes.