fix Rescale output is not working for advanced recordings#1729
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes advanced recording rescale output not being applied by configuring the recording video encoder’s scaled size when rescaling is enabled.
Changes:
- Add encoder scaling configuration (
obs_encoder_set_scaled_size) duringIAdvancedRecording::Start. - Set GPU scale type for the recording encoder when rescaling is enabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
summeroff
approved these changes
Jun 10, 2026
summeroff
pushed a commit
that referenced
this pull request
Jun 10, 2026
Fixes advanced recording rescale output not being applied by configuring the recording video encoder’s scaled size when rescaling is enabled. (cherry picked from commit 9eb083d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update
IAdvancedRecording::Startto callobs_encoder_set_scaled_size()when rescaling is enabled.After posting the PR, I received a defect from copilot that calling
obs_encoder_set_scaled_size&obs_encoder_set_gpu_scale_typecan mutate livestream filter.These are my notes after more digging:
useStreamEncoderscontrols whether the recording reuses the streaming output's video encoder instead of creating its own.It's set to true when the user selects "Use stream encoder" for recording (i.e., RecEncoder in the OBS config is "" or "none"):
This corresponds to the "Use stream encoder" option in Settings > Output > Recording > Video Encoder dropdown.
What happens in each case:
So the guard !recording->useStreamEncoders || obs_get_multiple_rendering() precisely covers the only safe cases where we can call obs_encoder_set_scaled_size(). In the dangerous
case (shared pointer, single rendering), the scaling calls are skipped — which means rescaling won't apply when "Use stream encoder" is selected, but that's actually correct
behavior since you can't independently rescale a shared encoder anyway.
Motivation and Context
In this pull request I updated frontend to properly migrate the rescaleRes but OSN had an issue where it did not utilize this scale.
How Has This Been Tested?
Manually ran Desktop, exported a recording with rescale output set, and verified when I opened the file it contained the resolution.
Types of changes
Checklist: