refactor: replace remaining sort.Slice calls with slices - #919
Open
luangucun wants to merge 1 commit into
Open
Conversation
GabrielCartier
requested changes
Sep 2, 2026
GabrielCartier
left a comment
GabrielCartier
left a comment
Contributor
There was a problem hiding this comment.
There are still a lot of call sites of sort.slice, you mind doing a sweep of the codebase to change it everywhere, then we can approve.
Signed-off-by: luangucun <luangucun@outlook.com>
luangucun
force-pushed
the
service/clock-sortfunc
branch
from
September 2, 2026 12:55
df46fb8 to
09e3234
Compare
Author
Done, thanks for pointing that out. I swept the codebase and replaced all remaining sort.Slice and sort.SliceStable call sites with the appropriate slices APIs (Sort, SortFunc, and SortStableFunc). There are no remaining sort.Slice usages in the codebase. |
Author
|
@GabrielCartier Please review it again. |
luangucun
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
replace remaining sort.Slice calls with slices
Testing
go test ./service/...