Repository navigation
Conversation
The SIGTERM and SIGINT handlers were registered after the IPC connect loop, so a signal during the retry wait killed the process and left the PID file behind. Register them first. While an IPC call is blocking, fall back to the default action, so a stuck node can't delay shutdown.
xyephy
marked this pull request as draft
November 12, 2026 09:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sv2-tp registered its SIGTERM and SIGINT handlers only after connecting to the node, so the
g_interruptchecks in the retry loop never fired. Stopping sv2-tp while it waited for the node killed it, and the PID file was left behind.This registers the handlers before connecting. While
connectAddress()ormakeMining()is blocking, the handler falls back to the default action, so a node that doesn't answer still can't delay shutdown, same as before.Not addressed here: once connected, a SIGTERM still waits for the node if it stops answering, because
isInitialBlockDownload()blocks. That was already the case on master.