Repository navigation
Conversation
sv1_api 8 replaces the four-variant envelope, so the reader decodes with Message::decode and the test builds the new Request and Response.
Notify, SetExtranonce and the other SV1 messages now come from the sv1_api root with renamed fields. The crate no longer re-exports the removed server_to_client module.
The trait has no setters, so the handlers write downstream state themselves and return results the router replies with. Decoding a downstream message is one ClientRequest::try_from, and a miner sending a response still disconnects.
Requests and notifications share one variant, IDs are sv1_api::Id, and notifications parse through ServerNotification.
…m branch Temporary: points stratum-core at bit-aloo/stratum 2026-11-10-sv1-api-redesign so CI builds against the companion stratum PR. Drop this commit and update stratum-core to stratum main once that PR lands.
sv1_api routers no longer return a reply or check session state, so each handler queues its own reply, records setup progress and forwards an accepted share upstream. The submit checks the router used to run (authorized worker, extranonce2 size, version bits) move into check_submit_session, and pending_share is gone.
ClientRequest and ServerNotification are now ClientToServer and ServerToClient.
bit-aloo
force-pushed
the
2026-11-10-sv1-api-redesign
branch
from
November 16, 2026 13:57
04e18c8 to
593c7bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
companion stratum-mining/stratum#2498