Repository navigation
fix(sv1_api): parse configure min-bit-count as decimal - #2414
Open
cfilipescu wants to merge 1 commit into
Open
cfilipescu wants to merge 1 commit into
cfilipescu wants to merge 1 commit into
Conversation
cfilipescu
force-pushed
the
agent/configure-min-bit-count-parsing
branch
2 times, most recently
from
October 7, 2026 13:58
3648586 to
0da6d63
Compare
Read string-valued min-bit-count hints as decimal integers. Log and ignore malformed or out-of-range values so a monitoring hint does not disconnect a miner; keep mask validation strict. stratum-mining#2412
cfilipescu
force-pushed
the
agent/configure-min-bit-count-parsing
branch
from
October 8, 2026 15:40
0da6d63 to
de00730
Compare
Contributor
Author
Member
|
any special reason why we're aiming to close #2412 with 3 different PRs? |
Contributor
Author
|
I thought I would make it easy to review by breaking it up into 3 smaller PRs that are mutually exclusive |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2412: parse the
version-rolling.min-bit-countrequest hint as a decimal integer in0..=32."16"now means 16 rather than hexadecimal 22. The old hex interpretation is removed.This is independently based on
mainfor focused review. It touches the same parser as #2413, applies cleanly with it, and the combinedsv1_apisuite passed. Malformed hints now appear as absent in monitoring; legacy eight-digit strings are read as decimal.Validation:
CC= CPATH= cargo test --locked -p sv1_api(37 passed),CC= CPATH= cargo +1.89.0 clippy --locked -p sv1_api --all-features -- -D warnings,cargo fmt --all -- --check --config-path /dev/null, and./scripts/check-version-bumps.sh origin/main.