Repository navigation
chore(deps): bump the cargo-dependencies group across 2 directories with 27 updates #2963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,4 +33,4 @@ serde_json = { workspace = true } | |
| [dev-dependencies] | ||
| vectorcraft-testkit = { workspace = true } | ||
| # Tests: a Group 4 encoder and the T.4 run codes, to write CCITT test images. | ||
| fax = "0.2" | ||
| fax = "0.3" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win 🔎 Supported by static analysis🏁 Script executed: rg -n -C 3 'fax::|encode_line\s*\(' crates/eps --glob '*.rs'Repository: storytold/vectorcraft Length of output: 4021 🏁 Script executed: set -eu
printf '%s\n' '--- crates/eps/Cargo.toml ---'
nl -ba crates/eps/Cargo.toml | sed -n '28,42p'
printf '%s\n' '--- Cargo.lock fax entries ---'
rg -n -A8 -B2 '^name = "fax"$|^name = "fax-' Cargo.lock || true
printf '%s\n' '--- caller block ---'
nl -ba crates/eps/src/import/tests_images.rs | sed -n '176,242p'
printf '%s\n' '--- repository fax API references ---'
rg -n -F --glob '*.rs' --glob '*.toml' --glob '*.lock' -e 'pub fn encode_line' -e 'encode_line(' -e 'name = "fax"' .Repository: storytold/vectorcraft Length of output: 4833 🌐 Web query:
💡 Result: 🌐 Web query:
💡 Result: Pass a
🐛 Suggested fix- encoder.encode_line(row.iter().map(|b| if *b { fax::Color::Black } else { fax::Color::White }), row.len() as u16).unwrap();
+ encoder.encode_line(row.iter().map(|b| if *b { fax::Color::Black } else { fax::Color::White }), row.len() as u32).unwrap();🤖 Prompt for AI Agents |
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,4 +22,4 @@ serde_json = { workspace = true } | |
| proptest = { workspace = true } | ||
| image = { workspace = true } | ||
| # A Group 4 encoder and the T.4 run codes, to write CCITT Group 3 TIFFs (`tiff::group3`). | ||
| fax = "0.2" | ||
| fax = "0.3" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win Pass a The caller in Proposed call-site fix- encoder.encode_line(row.iter().map(|b| if *b { fax::Color::Black } else { fax::Color::White }), row.len() as u16).unwrap();
+ encoder.encode_line(row.iter().map(|b| if *b { fax::Color::Black } else { fax::Color::White }), row.len() as u32).unwrap();🤖 Prompt for AI Agents |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🔴 Critical | 🏗️ Heavy lift
🔎 Supported by static analysis
🏁 Script executed:
Repository: storytold/vectorcraft
Length of output: 5848
🏁 Script executed:
Repository: storytold/vectorcraft
Length of output: 41677
🌐 Web query:
HarfRust 0.14.0 changelog UnicodeBuffer ShaperData ShaperInstance Buffer ShaperFont💡 Result:
🌐 Web query:
docs.rs harfrust 0.14.0 ShaperData shaper UnicodeBuffer ShaperInstance from_variations shape💡 Result:
Migrate the text shaper before raising HarfRust to 0.14.
HarfRust 0.14 uses
Buffer,ShaperFont, and in-placeshape, butcrates/text/src/shape.rsstill importsUnicodeBuffer, builds the shaper withface.shaper.shaper(&hb).instance(face.instance.as_ref()).build(), and passes aUnicodeBuffertoshape.crates/text/src/fontdb.rsalso stores and constructsShaperDataandShaperInstance. Migrate these callers before merging, orvectorcraft-textcan fail to compile against the locked HarfRust 0.14.0 dependency.🤖 Prompt for AI Agents