Repository navigation
Export: render in parallel once the GPU stops for good - #1511
Merged
Merged
Conversation
This was referenced Oct 15, 2026
eliasx45
added a commit
to eliasx45/effectcraft
that referenced
this pull request
Oct 15, 2026
Bring in shared color-picker sampling and trackpad pan/pinch navigation without duplicating the fork's Effect Console. Preserve floating-window input routing and owner-local cursors. Port marker-aware disk caching to the fork's memoized layer hashes, keeping protected timing markers and expression dependencies. Release the GPU export concurrency cap after permanent device failure. Give each effect step its own immutable host so GPU Echo sees preceding effects. Sources: storytold/effectcraft PRs storytold#1036, storytold#1328, storytold#1092, storytold#1511 and storytold#1412. Validation: cargo xtask ci --affected passed on the final combined tree (3983 tests passed, 44 skipped; strict Clippy, doctests, layers, assets and 16 WASM crates). Echo verified on Apple M1 Max Metal. Headless visual checks verified picker sampling and foreground ordering; added a regression for the modal layering fix. Physical trackpad input was not tested. Co-authored-by: pravdomil <2387356+pravdomil@users.noreply.github.com> Co-authored-by: nanox333 <kristian.myram@gmail.com> Co-authored-by: vangel76 <vangel1976@googlemail.com> Co-authored-by: Matej Kozlovský <100806068+MatejKozlovsky@users.noreply.github.com> Co-authored-by: arnav-hiwarkar <asharnav2008@gmail.com>
Member
|
Merged, thank you @MatejKozlovsky! It landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A GPU export renders at most
EFFECTCRAFT_GPU_INFLIGHTframes at once (1 by default, #879), so frames in flight don't exhaust VRAM. The cap stays on after the GPU has stopped for good: its device was lost, or it ran out of memory and its context was retired. From then on every frame is declined and rendered on the CPU, but still one at a time. A heavy 4K comp that runs out of GPU memory on its first frame then exports more slowly than with GPU acceleration off.Change
Accelerator::available()(defaulttrue). The GPU accelerator returnsfalseonce its context is unhealthy (check_health), which is the same condition that makes it decline every frame.Results
RTX 3090 (24 GB), Vulkan, 16 threads. Two 4K bench comps (generated by the bench scripts), 6 frames each, H.264. Both run out of GPU memory on frame 0 on current main.
available()staystrueand the cap applies as before.Tests
cargo fmt --check, pluscargo clippy --no-deps -D warnings(all targets) on effectcraft-export, effectcraft-render and effectcraft-gpu.cargo test -p effectcraft-export: 82 passed, including the newframes_render_in_parallel_once_the_gpu_stops.Notes
map_frames. If that lands first, the same check belongs in its GPU worker: stop applying the GPU limit onceavailable()is false.