Repository navigation
Conversation
LabDennis
force-pushed
the
fix/bounded-simulation-checkpoints
branch
from
October 14, 2026 17:33
c8eb9f9 to
ab4269f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long simulation seeks collected every 15-step snapshot before eviction. The final one-time thinning could still leave more than the intended 256 checkpoints, and peak state storage grew with the entire seek distance.
Refs #1238: addresses checkpoint accumulation and the retained-count limit.
One insertion helper now enforces the 256-checkpoint limit both while generating snapshots and while merging them into a cache entry. It drops off-grid targets first, thins aligned snapshots when needed, and keeps the new exact target. The simulator still executes the same steps and returns the same state; repeated requests for the latest target reuse its
Arcdirectly.Validation on Windows / Rust 1.95, upstream
549e9d82:xtask cistops at the unchangedcollapsible_matchfinding incrates/model/src/stl.rs:179; this PR does not claim a green full workspace CI run.The limit counts snapshots, not bytes: variable-sized states and concurrent runs still need a broader memory-budget design. Very large advances still execute synchronously and are not cancellable. Those remaining parts of #1238 are deliberately not marked closed by this focused fix.
Upstream main, issue status and open PRs were checked before publication. Existing broad performance PR #856 changes plane transposition in the same source file but does not touch
SimCache; #885 also does not provide this checkpoint fix.The branch is now based on upstream
05955c08b4fd. History: 1 → 1 commits. The rewritten file tree was checked against the previous PR plus current upstream, preserving prior integration resolutions.Scoped Windows regression checks: 1 passed, 0 ignored, zero failures. Formatting, locked Cargo metadata, asset and layer checks passed. This is scoped validation, not a new full-workspace or cross-platform CI claim.