Repository navigation
build: pin craft-update to craft-libs main (495e597) - #1386
Conversation
Picks up the update prompt fix that draws its close mark and version pill without glyphs a font may lack, so the prompt no longer takes the app down when a bundled face has no ✕ or →. Part of tracking issue storytold/craft-libs#319 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Update craft-update pin Cargo.toml |
The craft-update Git dependency now uses revision 495e5971bc024aa96e6ed318cb6e7cd3a0103184 instead of db19c373c8d59a545972ca340987aecfb3611a4b. The version constraint and egui feature are unchanged. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix
Possibly related PRs
- storytold/deckcraft#1377: Both PRs change the
craft-updaterevision inCargo.toml; this PR updates the pin used by the update prompt introduced there.
Suggested reviewers: echelon
Merge Risk: 
528a2
-
The pin update is consistent and introduces no identified merge-blocking risk.
Architecture risk: 
528a2
-
The change affects 1 system.
Changed systems:
Cargo.tomlArchitecture concerns
No architecture-level concerns identified.Review details
-
Systems and components
- observed — Cargo.toml (service) was modified; 1 changed file maps to changed impact.
Before / after behavior
- observed — Modified behavior in Cargo.toml: The
craft-updateGit dependency revision changes fromdb19c373c8d59a545972ca340987aecfb3611a4bto495e5971bc024aa96e6ed318cb6e7cd3a0103184; the version constraint andeguifeature remain unchanged.
-
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly identifies the main change: pinning the craft-update dependency to the specified craft-libs revision. Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
Picks up storytold/craft-libs#344: the update prompt draws its close mark as two painted strokes and its version pill as
v0.1.0 to 0.2.0, instead of the ✕ (U+2715) and → glyphs that no bundled face is guaranteed to have. On the egui fork that panics on a missing glyph, that took the prompt — and the app — down.The only change between the previous pin and this one is
crates/update/src/dialog.rs, with no public API change.Part of tracking issue storytold/craft-libs#319
🤖 Generated with Codebuff
Co-Authored-By: Codebuff noreply@codebuff.com
Summary by CodeRabbit