update storybook deps to 10.5.4 - #913
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: e3e3e18 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Allows CI to install freshly published Storybook releases before the ~22h supply-chain age gate elapses. Co-authored-by: Cursor <cursoragent@cursor.com>
Ensures upgrading RN packages pulls users onto the core release that infers framework metadata for .rnstorybook configs. Co-authored-by: Cursor <cursoragent@cursor.com>
github-project-automation
Bot
moved this from In Progress
to Done
in Core Team Projects
Member
|
This change makes the requirement 10.5.4 instead of ^10.5.2 which doesn't seem necessary and also locks in a specific patch version |
Member
Author
|
Yes, that was the point, unfortunately required for telemetry to work correctly. |
Member
Author
|
Oh, wait it should have a caret version, I'll fix that today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
storybook,@storybook/react, and@storybook/react-native-web-viteto 10.5.4 across packages and examples.rnstorybookconfigs that omitframework(storybookjs/storybook#35560), sometadata.framework.nameresolves to@storybook/react-nativeTest plan
pnpm installresolves 10.5.4 (may need--config.minimum-release-age=0until the release ages pastminimumReleaseAge)STORYBOOK_TELEMETRY_DEBUG=1telemetry('dev', …, { configDir: '.rnstorybook' })withoutmain.frameworkreportsframework.name: "@storybook/react-native"Made with Cursor