Repository navigation
fix(make): discover lowercase makefile and GNUmakefile - #531
Open
DazorPlasma wants to merge 2 commits into
Open
DazorPlasma wants to merge 2 commits into
DazorPlasma wants to merge 2 commits into
Conversation
DazorPlasma
force-pushed
the
fix/makefile-name-discovery
branch
from
October 9, 2026 19:37
7287350 to
318dc7b
Compare
DazorPlasma
force-pushed
the
fix/makefile-name-discovery
branch
from
October 9, 2026 19:37
7af988a to
24b65ec
Compare
DazorPlasma
marked this pull request as ready for review
October 9, 2026 19:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Make provider currently searches only for
Makefile, so projects using the conventional lowercasemakefileorGNUmakefileproduce no task templates even thoughmakeworks in those directories.Recognize all three default GNU Make filenames, in the order
GNUmakefile,makefile,Makefile, while preserving the upward search for the closest directory. This also makes the provider's cache key match the file thatmake -rRpqreads when multiple default filenames exist.Add regression tests using real Make target discovery for each filename, filename precedence, discovery from subdirectories, and missing Makefiles. The discovery tests also verify that recipes are not executed.
Validation on Neovim 0.12.5:
stylua --check lua tests: passed.luacheck lua tests: passed (0 warnings/errors; repository configuration excludes tests).git diff --check: passed.