Repository navigation
fix: correct dependency resolution for nested actions and deletions (… - #790
Open
theAnuragMishra wants to merge 1 commit into
Open
theAnuragMishra wants to merge 1 commit into
theAnuragMishra wants to merge 1 commit into
Conversation
…tevearc#780) Fixes an issue where deleting a parent directory while moving or copying descendant items out of it caused the deletion to execute first, deleting the items before they could be moved. - Fix Trie:_dfs using ipairs over container.children (a string-keyed map), which prevented discovering nested descendants in dependency checks (accum_children_of), and ensure filter is forwarded. - Normalize trailing slashes in Trie:_url_to_path_pieces so paths with and without a trailing slash resolve to the same trie node. - Safely check for missing parent containers in accum_first_parents_of. - Defer independent deletes after non-destructive operations (create, move, copy, change) while preserving explicit dependencies (such as deleting a destination before moving/copying into it). - Add copy checks to delete dependencies so reading from a path to copy it completes before deleting that path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #780 .
Fixes an issue where deleting a parent directory while moving or copying descendant items out of it caused the deletion to execute first, deleting the items before they could be moved.
Note: I wrote this PR with AI assistance but have fully verified the changes myself, ran tests and also manually tested a lot of variations of moves and deletes in bulk including one specified in #780 .