Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
open_preview callback + return when the source window/buffer or existing preview window is no longer valid resolve path and open the previewFixes #772. If the Oil window closes while
get_edit_path()is still resolving, the delayed callback can use the closed window ID and raiseInvalid window id. The guard also skips the callback if the source window has switched away from the captured Oil buffer. This is independent of #632 / #769, which addresses loading an already initialized preview buffer.Evidence
Invalid window id: 1002.move_rename_spec.lua; the same two failures occurred on the unmodified base commitd3733d9.Merge Danger
Door: Two-way. The callback exits when its captured window state is gone.
Blast Radius: Low. The change is confined to preview callback handling and its regression test.