Repository navigation
Conversation
Preload and generated multi-hop Joins suffixed table aliases with the process-global bob.NextUniqueInt counter, so building the same query twice produced different SQL and defeated pgx prepared-statement caching (stephenafamo#741). Aliases now come from a counter on bob.Load (NextQueryAlias: bob_q0, bob_q1, ...). Preloader.Apply passes the query's allocator to the preload tree through the new orm.WithNextAlias option, and generated multi-hop joins allocate intermediate aliases when applied. Preloaders called without an allocator fall back to unique bob_g aliases. Also fixes two Preload bugs found along the way: - PreloadAs on multi-side relationships aliased every side, producing duplicate aliases; it now applies only to the final side. - to_where columns were qualified with the parent table instead of the joined table, producing invalid or incorrect ON clauses. BREAKING CHANGE: orm.Preloader now takes optional ...orm.PreloaderOpt after parent. Calls such as loader("") still compile, but functions declared with the old exact signature must add the variadic parameter.
jalaziz
force-pushed
the
fix/741-stable-query-aliases
branch
from
October 12, 2026 04:23
dbf6b35 to
edee13e
Compare
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preload and generated multi-hop Joins suffixed table aliases with the process-global bob.NextUniqueInt counter, so building the same query twice produced different SQL and defeated pgx prepared-statement caching (#741).
Aliases now come from a counter on bob.Load (NextQueryAlias: bob_q0, bob_q1, ...). Preloader.Apply passes the query's allocator to the preload tree through the new orm.WithNextAlias option, and generated multi-hop joins allocate intermediate aliases when applied. Preloaders called without an allocator fall back to unique bob_g aliases.
Also fixes two Preload bugs found along the way:
BREAKING CHANGE: orm.Preloader now takes optional ...orm.PreloaderOpt after parent. Calls such as loader("") still compile, but functions declared with the old exact signature must add the variadic parameter.
Fixes #741