Repository navigation
feat: persist submitted transaction hash - #7
Merged
Merged
Conversation
ZeePearl56
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
submission_hashcolumn for the actual transaction hash returned after successful network submission.submissionHashthroughGET /requests/:id.tx_hashfield distinct as the unsigned transaction envelope hash.Why
The API previously received the real submitted transaction hash from Horizon but discarded it. The frontend therefore had to reconstruct a hash locally from the transaction fragment, which is unavailable to every viewer of a submitted request.
This PR makes the coordinator API the source of truth for the actual submission hash.
Testing
npm test— 44/44 passednpm run typecheck— passednpm run lint— passedgit diff --check— cleanScope
This PR is intentionally limited to submission-hash persistence and exposure.
It does not implement reconciliation of ambiguous/stuck submissions, dependency upgrades, rate limiting, decoder-equivalence testing, or frontend consumption of the new field. Those are separate engineering units.