Repository navigation
fix: omit unset setOptions fields from transaction summary - #10
Merged
Merged
Conversation
ZeePearl56
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setOptionsdecoder handling of absent optional numeric fields.nullfrom appearing in signer-facing transaction summaries.0, as real transaction instructions.Problem
@stellar/stellar-sdkrepresents absentOptional<uint32>values inSetOptionsOpasnull.The decoder previously checked those fields with
!== undefined, causingabsent fields to render as literal
null.That inaccurately suggested the transaction was modifying account properties
that were actually untouched.
Fix
The six affected guards now use
!= null:Absent fields are omitted from the summary, while explicit values such as
masterWeight: 0remain visible.Testing
npm test— 56/56 passednpm run typecheck— passednpm run lint— passedgit diff --check— cleanScope
This PR only changes the
setOptionsdecoder behavior and its regressioncoverage.
No signing, submission, database, dependency, or CI behavior was changed.
The corresponding coordinator-web fix will be landed separately to preserve
the two-repository decoder parity.