Repository navigation
Add ICU plural/select support, new locale catalogs, and en-XA pseudo-locale - #564
Merged
Merged
Conversation
…nd en-XA pseudo-locale Closes stellar-vortex-protocol#495
|
@aishabellova Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
# Conflicts: # scripts/check-i18n-parity.mjs # src/lib/i18n/messages/en.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add ICU plural/select support, new locale catalogs, and en-XA pseudo-locale
What was solved
#495 — [High] Add new locale catalogs (pt-BR, fr, zh-CN) with ICU plurals, placeholder parity checks and a pseudo-locale for testing
Add ICU-style plural/select support to the i18n system via Intl.PluralRules, introduce pt-BR/fr/zh-CN catalogs plus a generated en-XA pseudo-locale, extend the parity checker to validate placeholders/plural categories/lengths, and wire the pseudo-locale into dev via ?lang=en-XA and the Storybook toolbar.
Addressed:
{count, plural, one {…} other {…}}(and select) resolved viaIntl.PluralRules(locale).Changes
src/lib/i18n/index.ts(modify)src/lib/i18n/messages/en.ts(modify)scripts/check-i18n-parity.mjs(modify)Approach
Issues
Closes #495