Repository navigation
Conversation
…t support with logical CSS Closes stellar-vortex-protocol#496
…currency, date and relativ Closes stellar-vortex-protocol#497
|
@kerenaugustine79 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
# Conflicts: # src/lib/decimal.ts # src/lib/format.ts # src/lib/i18n/index.ts # src/lib/textSafety.ts # src/lib/time.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: address #496, #497, #498, #499
What was solved
#496 — [High] Add right-to-left (RTL) layout support with logical CSS properties and an Arabic/Hebrew smoke locale
Add RTL layout support by converting physical Tailwind direction utilities to logical ones across components/pages, mirroring direction-sensitive UI with rtl: variants, isolating mixed-direction content (addresses/hashes/amounts) via bdi/dir=ltr, adding an Arabic smoke locale with dir on , and providing a codemod script plus RTL checklist. Out of scope: full professional Arabic/Hebrew translations.
Addressed:
#497 — [High] Build a locale-aware number, currency, date and relative-time formatting layer including decimal-separator-aware amount input
Add an Intl-backed, locale-aware formatting layer (useFormatters hook + server equivalent) with cached Intl instances and safe fallbacks, migrate amount/USD/percent/timestamp UI to it, and make the SwapCard amount input locale-aware (decimal separators, grouping, paste disambiguation, IME-safe, inputmode=decimal, accessible label).
Addressed:
#498 — [High] Establish Core Web Vitals budgets with Lighthouse CI and fix the top regressions
Add a Lighthouse CI performance gate (desktop + mobile emulation) with Core Web Vitals and bundle-size budgets for at least four routes, wire it into CI to run against a production build and comment results on PRs with trend artifacts, land at least three concrete optimisations with measured before/after, audit and fix layout shifts (reserved dimensions for feeds, skeletons, banners like ConnectivityBanner and onboarding hints), and document budgets plus a local
npm run perfworkflow.Addressed:
lighthouserc.jsonwith budgets (LCP < 2.5s, CLS < 0.1, TBT < 200ms on emulated mid-tier mobile) covering at least four routes including/,/explore,/solve.#499 — [High] Cut initial JavaScript with route-level code splitting, lazy Stellar SDK and LazyMotion
Reduce first-load JavaScript by introducing route-level code splitting, a memoised dynamic Stellar SDK loader used at signing/verification time, framer-motion LazyMotion with domAnimation, and per-route bundle budgets enforced in scripts/check-bundle-size.mjs, with a documented baseline in docs/performance.md.
Addressed:
Changes
src/app/globals.css(modify)tailwind.config.ts(modify)src/lib/i18n/index.ts(modify)src/lib/textSafety.ts(modify)src/lib/format.ts(modify)src/lib/time.ts(modify)src/lib/decimal.ts(create)lighthouserc.json(create).github/workflows/ci.yml(modify)src/app/layout.tsx(modify)README.md(modify)src/lib/xdrReview.ts(modify)scripts/check-bundle-size.mjs(modify)next.config.mjs(modify)docs/performance.md(create)Approach
Issues
Closes #496
Closes #497
Closes #498
Closes #498
Closes #499
Closes #499