Repository navigation
Governance: proposal progress visualization with lifecycle states - #557
Merged
james2177 merged 5 commits intoSep 30, 2026
Merged
Conversation
…imelock progress visualiza Closes stellar-vortex-protocol#472
…ard with templates, live p Closes stellar-vortex-protocol#473
… for proposals and comment Closes stellar-vortex-protocol#474
…low: delegate, revoke and Closes stellar-vortex-protocol#475
|
@devoclan Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
# Conflicts: # src/hooks/useLocalStorageDraft.ts # src/lib/governanceStore.ts # src/lib/stellarAddress.ts # src/lib/textSafety.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Governance: proposal progress visualization with lifecycle states
What was solved
#472 — [High] Build quorum, threshold and timelock progress visualizations with accessible status semantics
Add governance proposal progress visualizations: a pure
deriveProposalState(proposal, now)state machine plus a presentationalProposalProgresscomponent (stacked for/against/abstain bar with quorum and threshold markers, textual status, accessible progressbar/meter semantics), wired into governance list cards and detail page, with localized copy and lifecycle states (active → succeeded/defeated → queued with timelock countdown → executed/expired).Addressed:
ProposalProgresscomponent with stacked bar (for/against/abstain), quorum marker, threshold marker, and textual status such as "Quorum met, approval 62% / 66% needed".role="progressbar"/meter with descriptive accessible labels.active → succeeded/defeated → queued (timelock ends in …) → executed/expired, derived by a pure function from proposal data, and display next actions.#473 — [High] Build a proposal creation wizard with templates, live preview, validation and deposit handling
Implement a guided, multi-step governance proposal creation wizard under src/app/governance/new with a template registry (parameter change, routing, solver policy), Markdown description editor with safe preview and sanitisation, typed parameter fields with current→proposed diffs, per-wallet draft persistence with TTL and resume banner, eligibility/deposit gating, and a transaction review/sign step. Scope is limited to the wizard UI, template registry, draft hook, and XDR review helper — contract-level proposal execution logic is explicitly out of scope.
Addressed:
#474 — [High] Ship a safe Markdown renderer for proposals and comments with a strict sanitization policy
Add a safe, dependency-light Markdown renderer for governance proposals and comments that parses Markdown into an AST and renders React elements directly (no dangerouslySetInnerHTML), enforcing a strict URL/content policy, size/complexity limits, and text sanitization, with an XSS corpus test and a security-audit doc section.
Addressed:
#475 — [High] Build the voting delegation flow: delegate, revoke and delegate directory
Implement the governance voting delegation flow: a delegation panel (current delegate, delegated power, history) with delegate/revoke forms running the review → simulate → sign pipeline, plus a searchable/sortable delegate directory with sanitised profiles. New-address delegation requires full-address confirmation (address-poisoning defence) and warns on self-delegation or non-existent accounts. Effective voting power updates on useVotingPower after confirmation, with pending state handling. Adapter + MSW mock behind a feature flag when endpoints are unavailable.
Addressed:
Changes
src/lib/governanceStore.ts(modify)src/lib/textSafety.ts(modify)src/lib/stellarAddress.ts(modify)src/components/Markdown.tsx(create)src/hooks/useDelegation.ts(create)src/hooks/useLocalStorageDraft.ts(modify)src/app/governance/delegates/page.tsx(create)Approach
Issues
Closes #472
Closes #473
Closes #474
Closes #475