Support configurable file uploads disk - #133
Merged
Merged
Conversation
Member
Author
|
Converting to a draft until the core PR is merged. |
duncanmcclean
marked this pull request as draft
May 27, 2026 09:19
Neither method is called anywhere in the codebase.
str_starts_with($path, '/') only matched Unix-style paths, so imports saved with a Windows absolute path (eg. C:\...) on older versions wouldn't have been detected as legacy paths correctly.
getLocalFilePath() and deleteFile() branch on whether an import's stored path is a legacy absolute path or a new relative one, but that branch wasn't covered by any test.
duncanmcclean
marked this pull request as ready for review
July 20, 2026 09:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the importer to support the configurable file uploads disk introduced in statamic/cms#14733.
In multi-server environments where a file might be uploaded on one server but processed on another, the CMS now allows configuring a shared filesystem for temporary file uploads. This PR ensures the importer reads uploaded files from the configured disk rather than hardcoding to the
localdisk.Changes
Configurable uploads disk
The
ImportControllernow reads the uploads disk and path from thestatamic.systemconfig. Files are still moved to thelocaldisk for import processing sinceSimpleExcelReaderandXMLReaderrequire filesystem paths.Relative path storage
Import files are now stored with relative paths (eg.
statamic/imports/posts/import.csv) instead of absolute paths. This makes imports portable and works correctly with Laravel's Storage API.Related: statamic/cms#14733