Skip to content

[ci] restore macOS CI and retain the timeout test transaction (STAR-100) - #22

Draft
vt128 wants to merge 2 commits into
masterfrom
codex/ci-macos15-adoption-20261107
Draft

vt128 wants to merge 2 commits into
masterfrom
codex/ci-macos15-adoption-20261107

Conversation

@vt128

@vt128 vt128 commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Both macOS matrix legs were cancelled before tests ran because the shared workflow selected the retired macos-14 image. Adopt the verified 1set/meta workflow at 6b334e6a2762acaeefcea9fc7d3e86964e9246be (meta #16), which uses macos-15. All caller inputs, the Go 1.20 floor, dependencies, interpreter pin and coverage thresholds remain unchanged.

The new Windows Go 1.27 job exposed a separate lifetime error in TestNestedBeginHonorsTimeout: the test discarded its first transaction. GC could then correctly finalize that abandoned handle and release the sole connection, allowing the second begin to succeed. A separate [test] commit retains the first handle through the second call, forces GC during the regression, checks the deadline error and explicitly rolls back during cleanup. The real 200 ms operation deadline and 5 s outer guard are retained; production transaction code is unchanged.

Validation:

  • In an isolated copy, forcing GC against the original test reproduced the same failure 3/3 times after the connection returned to the pool.
  • The retained-handle regression passed 20 repeated race runs on Go 1.27.3.
  • Local full build/race-count=2/vet/format passed.
  • Offline Linux amd64 Go 1.20.14 passed build, 10 targeted race repetitions, full race-count=2 and vet.
  • The unchanged pre-commit hook and workflow actionlint passed.

Keep this PR draft until the new exact-head matrix and external Project/Patch statuses are verified. No protection rules were changed. Enabled-UDF budget and lifecycle work remains tracked separately in STAR-102.

Refs STAR-100.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@vt128 vt128 changed the title [ci] restore supported macOS runners (STAR-100) [ci] restore macOS CI and retain the timeout test transaction (STAR-100) Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant