Repository navigation
Conversation
Up to standards ✅🟢 Issues
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both macOS matrix legs were cancelled before tests ran because the shared workflow selected the retired macos-14 image. Adopt the verified
1set/metaworkflow at6b334e6a2762acaeefcea9fc7d3e86964e9246be(meta #16), which uses macos-15. All caller inputs, the Go 1.20 floor, dependencies, interpreter pin and coverage thresholds remain unchanged.The new Windows Go 1.27 job exposed a separate lifetime error in
TestNestedBeginHonorsTimeout: the test discarded its first transaction. GC could then correctly finalize that abandoned handle and release the sole connection, allowing the second begin to succeed. A separate[test]commit retains the first handle through the second call, forces GC during the regression, checks the deadline error and explicitly rolls back during cleanup. The real 200 ms operation deadline and 5 s outer guard are retained; production transaction code is unchanged.Validation:
Keep this PR draft until the new exact-head matrix and external Project/Patch statuses are verified. No protection rules were changed. Enabled-UDF budget and lifecycle work remains tracked separately in STAR-102.
Refs STAR-100.