Skip to content

[ci] restore repeatable checks at the Go 1.20 floor (STAR-100) - #20

Merged
vt128 merged 4 commits into
masterfrom
codex/sqlite-ci-prerequisites
Sep 23, 2026
Merged

vt128 merged 4 commits into
masterfrom
codex/sqlite-ci-prerequisites

Conversation

@vt128

@vt128 vt128 commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

The SQLite CI caller still used the old shared workflow and Go 1.25 comparison leg. Adopt the verified shared workflow with GitHub OIDC coverage uploads, current Go 1.27 checks and the complete configuration-documentation contract. Keep the existing Go 1.20 floor, every dependency and the fixed Starlark interpreter unchanged; add an explicit compatibility check.

The required repeated race run also exposed a pre-existing test failure: the custom-function example reused five process-global SQL function names on its second run. Apply one fresh namespace to every registration and SQL call using the existing test helper, and run the full CI test suite twice. No runtime registry or isolation behavior changes; the separate SQLite UDF budget and instance-isolation work remains open.

Validation:

  • Reproduced the duplicate-name failure on Go 1.27.1 and offline Linux amd64 Go 1.20.14 before the fix.
  • Five consecutive custom-function example runs and full race tests twice passed after the fix.
  • Local and offline Go 1.20 build, vet and formatting passed; local make ci and unchanged go mod tidy passed.
  • Documentation contract: all 29 builtins and 16 config accessors are documented; actionlint passed.

Refs STAR-100. Merge still requires the actual Codecov Project and Patch checks; successful uploads alone do not satisfy that gate.

  • Compared the exact PR base and final source in offline Linux amd64 Go 1.20: build and race tests passed on both; statement coverage stayed at 74.9%, above the existing 69% minimum.

A one-time job uploaded coverage for the exact base commit 13bc2629401407023a4cb900a707d6f889b05ce7, and was removed in a separate commit. The final tree contains only the shared-workflow update, the compatibility check and the repeatable test change. All 12 reported checks pass on 6d0bf2dae16f50a5983a52a39efe7cfbf394eca9, including Codecov Patch; Codecov Project is still not reported. No merge or release has been performed.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@vt128
vt128 merged commit 60b72f6 into master Sep 23, 2026
12 checks passed
@vt128
vt128 deleted the codex/sqlite-ci-prerequisites branch September 23, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant