Repository navigation
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
vt128
force-pushed
the
codex/s3-part-size-config-20261107
branch
from
November 7, 2026 15:36
624d3fc to
b31b5aa
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
vt128
changed the base branch from
codex/ci-contract-adoption-20261107
to
master
November 12, 2026 01:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve configured
part_sizevalues when creating an S3 client. The option is declared asint64, but the client constructor requested anint, so module or host settings such as 8 MiB were silently replaced by the 5 MiB default. Use the existing typed base getter while retaining the default and explicit per-client override behavior.Refs STAR-25 / PKG-15; local tracking LOCAL-018. This PR directly targets master and supersedes #20. It includes that PR’s complete supported-runner and stacked-PR CI changes unchanged; the completed temporary baseline workflow remains removed.
Validation:
create_client().get_client_info()API; default and explicit override controls passed.-race -count=2suite, and vet. Statement coverage stayed exactly 525/917 with identical hit/unhit blocks.Scope:
part_sizeandconcurrencyare stored and reported only. Multipart/concurrent transfers remain unimplemented; existing SDK security findings are separate. The README now states that boundary.Local validation does not replace this PR’s required exact-head CI and coverage gates, including Codecov Project. This remains Draft until actual checks and coverage statuses are available on the appropriate final head.