Skip to content

[fix] preserve configured int64 part_size (STAR-25) - #21

Draft
vt128 wants to merge 4 commits into
masterfrom
codex/s3-part-size-config-20261107
Draft

vt128 wants to merge 4 commits into
masterfrom
codex/s3-part-size-config-20261107

Conversation

@vt128

@vt128 vt128 commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Preserve configured part_size values when creating an S3 client. The option is declared as int64, but the client constructor requested an int, so module or host settings such as 8 MiB were silently replaced by the 5 MiB default. Use the existing typed base getter while retaining the default and explicit per-client override behavior.

Refs STAR-25 / PKG-15; local tracking LOCAL-018. This PR directly targets master and supersedes #20. It includes that PR’s complete supported-runner and stacked-PR CI changes unchanged; the completed temporary baseline workflow remains removed.

Validation:

  • Test first: environment, typed host and module setter cases failed through the public create_client().get_client_info() API; default and explicit override controls passed.
  • Host Go 1.27.3 and Linux/amd64 Go 1.21.13 baseline/upgrade legs passed build, the complete default -race -count=2 suite, and vet. Statement coverage stayed exactly 525/917 with identical hit/unhit blocks.
  • A final test-only 3 GiB metadata case, above MaxInt32, passed targeted race2 on both compilers. It creates no payload and sends no S3 request. The unchanged production code and module files match the four full-suite inputs.
  • The original pre-commit hook passed. Go 1.21, the fixed Starlark pin, and go.mod/go.sum are unchanged.
  • Fresh module inputs matched all 20 active plus one archived diagnostic ecosystem graphs; no other known active Go module selected S3. External/private consumers and opt-in live S3 fixtures were not exercised.

Scope: part_size and concurrency are stored and reported only. Multipart/concurrent transfers remain unimplemented; existing SDK security findings are separate. The README now states that boundary.

Local validation does not replace this PR’s required exact-head CI and coverage gates, including Codecov Project. This remains Draft until actual checks and coverage statuses are available on the appropriate final head.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@vt128
vt128 force-pushed the codex/s3-part-size-config-20261107 branch from 624d3fc to b31b5aa Compare November 7, 2026 15:36
@codecov

codecov Bot commented Nov 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@vt128
vt128 changed the base branch from codex/ci-contract-adoption-20261107 to master November 12, 2026 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant