Repository navigation
[fix] bind llm credentials to host policy (STAR-103) - #19
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 56 |
| Duplication | 2 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
NewModuleandNewModuleWithConfigintentionally let a script choose the LLM provider and endpoint. That behavior is useful for trusted scripts, but a host-injected credential could then be sent to a script-selected endpoint;image_filecould also read any host-readable file.Change
NewModuleWithHostPolicy(HostPolicy{...})for opt-in host-controlled embedding.FileRootonce and reject traversal, symlink escapes, non-regular files, and file access when the root is empty.NewModuleandNewModuleWithConfig.The change keeps Go 1.19, the existing Starlark pin, and all module dependencies unchanged.
Validation
go test -race -count=2 ./...go test -race -count=1 ./...,go build ./...,go vet ./...go vet ./...,go build ./...,gofmt,git diff --checkimage_fileentry points, traversal/symlink rejection, redirect rejection, invalid policy errors, and the legacy constructors.