Repository navigation
[fix] require host grants for script environment keys - #20
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 15 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A command allowlist could be bypassed through script-supplied application environment hooks such as
GIT_CONFIG_*,BASH_ENVor interpreter startup options. Require exact host-granted environment keys before starting restricted commands, across per-call env, set_env and CMD_ENV (STAR-95).Add
NewModuleWithPolicy(Policy{Commands, EnvKeys})with defensive copies.NewModuleWithAllowgrants no environment overrides; existing callers needing them must migrate to explicit grants. Names follow the OS case rules, unknown keys produce deterministic errors without values, and the complete script-facing module surface is pinned by a golden assertion. TrustedNewModuleWithAllowAllretains its environment behavior and dynamic-linker stripping.This addresses the module's config/call inputs; hosts must also prevent untrusted mutation of global process environment or executable files through other modules. Go 1.19 and the pinned Starlark version are unchanged.
Validation: pre-fix reproductions, build, race tests twice, vet, formatting, document coverage, and Go 1.19 Linux amd64 tests with networking disabled. Depends on #19 for the already-reviewed dependency-floor and CI corrections; merge #19 first. No release is requested by this PR.