Skip to content

[ci] restore macOS runners and documentation checks (STAR-100) - #27

Closed
vt128 wants to merge 2 commits into
masterfrom
codex/ci-contract-adoption-20261107
Closed

vt128 wants to merge 2 commits into
masterfrom
codex/ci-contract-adoption-20261107

Conversation

@vt128

@vt128 vt128 commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Superseded by #28. All changes from this PR are preserved unchanged in that PR, which now directly targets master and retains its existing Draft/HOLD gates. Closing this duplicate presentation does not mean the replacement is merged or its pending acceptance is complete.

Original description and validation record follow.

The current CI matrix selects the retired macos-14 image, cancelling both macOS test legs before tests run. Adopt the verified shared workflow at 1set/meta@6b334e6a2762acaeefcea9fc7d3e86964e9246be (meta #16), which uses macos-15.

The same adoption completes the AST-based documentation checks tracked by STAR-93: the older convention scanner can require nonexistent setters for host-only options and miss multiline declarations. Use Codecov OIDC with the required caller permissions. The existing floor and Go 1.27 comparison legs are retained. Preserve the declared Go floor, dependencies, interpreter pin, coverage minimum, documentation options and footprint thresholds.

Validation:

  • actionlint v1.7.12 and the pinned AST documentation/configuration contract passed.
  • Every local commit passed the unchanged gofmt/vet/full-test pre-commit hook; git diff --check passed.
  • Workflow inputs and other configuration semantics retain their original values.

This PR remains draft while the new remote matrix and external Codecov Project/Patch statuses are verified. Required check names need coordinated migration where they still refer to the old Go/macOS legs; this PR does not modify branch protection.

Refs STAR-100; documentation contract adoption also tracks STAR-93.

@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@vt128 vt128 changed the title [ci] adopt current documentation checks (STAR-93) [ci] restore macOS runners and documentation checks (STAR-100) Nov 6, 2026
@vt128 vt128 closed this Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant