Repository navigation
Restore the tomeliot_dev API surface steer-financing depends on (0.2.24) - #51
Merged
Merged
Conversation
steer-financing was developed against the tomeliot_dev branch, which forked
before main's history was rewritten and was never merged back. None of its 13
demos ran against main and 26 of its serialization tests failed. Merging the
branch is not viable -- it is ~3 months stale and lacks 15 main-only symbols
with 79 downstream call sites (apply_plot_layout, Periodic_table, the 0.2.21
deserialization allowlist), and the rewritten history makes the merge conflict
in 28 files / 85 hunks for a real content delta of 13 files.
Port the four additions instead. All are additive; no existing behaviour
changes and steer-core's own 376 tests are unaffected.
- Constants/Format.py: DEFAULT_MONTH_FMT ("%Y-%m")
- ValidationMixin.validate_not_none / validate_active_mode
- SerializerMixin honours a _serializer_exclude hook, so a subclass can skip
transient caches holding objects msgpack cannot encode. Without it
steer_financing's cached pd.DatetimeIndex made every serialize() raise
TypeError: can not serialize 'DatetimeIndex' object.
- SerializerMixin round-trips timedelta and set
Verified: steer-core 376 passed / 0 failed; steer-financing's suite is
set-identical to the tomeliot_dev baseline (zero regressions) and fully green
once its optional deps are installed.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
steer-financing was developed against the tomeliot_dev branch, which forked before main's history was rewritten and was never merged back. None of its 13 demos ran against main and 26 of its serialization tests failed. Merging the branch is not viable -- it is ~3 months stale and lacks 15 main-only symbols with 79 downstream call sites (apply_plot_layout, Periodic_table, the 0.2.21 deserialization allowlist), and the rewritten history makes the merge conflict in 28 files / 85 hunks for a real content delta of 13 files.
Port the four additions instead. All are additive; no existing behaviour changes and steer-core's own 376 tests are unaffected.
Verified: steer-core 376 passed / 0 failed; steer-financing's suite is set-identical to the tomeliot_dev baseline (zero regressions) and fully green once its optional deps are installed.