ROX-35606: chore: remove writeExampleBundle#21550
Draft
guzalv wants to merge 1 commit into
Draft
Conversation
Remove two startup functions that are no longer needed: - writeExampleBundle(): wrote bundle.example.json as a format reference. Redundant because the format is documented in Helm values and operator CRD descriptions. The file is also shadowed when the new ConfigMap mount (from redHatSigningKeyBundle) is active. - ensureKeyBundleDirectory(): created /tmp/redhat-signing-keys/. Redundant because the filedownloader already calls os.MkdirAll and the filewatcher handles missing files gracefully. Partially generated by AI.
|
Skipping CI for Draft Pull Request. |
Contributor
🚀 Build Images ReadyImages are ready for commit bb63318. To use with deploy scripts: export MAIN_IMAGE_TAG=4.12.x-391-gbb633182ce |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove two startup functions that are no longer needed:
writeExampleBundle(): wrotebundle.example.jsonas a formatreference for offline customers. Redundant because the format is
documented in the Helm values example and operator CRD description.
The file is also shadowed when the
redHatSigningKeyBundleConfigMapmount is active (directory mount makes the path read-only).
ensureKeyBundleDirectory(): created/tmp/redhat-signing-keys/.Redundant because the
filedownloaderalready callsos.MkdirAll(
pkg/filedownloader/filedownloader.go:108) and thefilewatcherhandles missing files gracefully
(
pkg/filewatcher/filewatcher.go:105).54 lines removed, 0 added.
Depends on #21549.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
./central/signatureintegration/...pass (17 tests)filedownloadercreates its own directory andfilewatcherhandles missing filesPartially generated by AI.