You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
raisePolicyError(f"Invalid policy schema in {path}: unsupported keys: {', '.join(unknown_keys)}.")
Validate policy keys as strings before unknown-key formatting
When a policy file has non-string top-level keys (which YAML allows), this path can raise a TypeError while sorting/joining unknown keys, so the CLI emits a traceback instead of the documented PolicyError/exit code 2 flow. This is user-visible on malformed policies and should fail cleanly with a schema error rather than crashing.
raisePolicyError(f"Invalid policy schema in {path}: max_added_packages must be a non-negative integer.")
Reject boolean values for max_added_packages
The schema check uses isinstance(max_added_packages, int), but YAML booleans deserialize to bool, which is an int subclass in Python. A policy like max_added_packages: false is accepted and treated as 0, causing unexpected blocking violations whenever any package is added. This should be rejected as invalid schema input.
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification