Skip to content

feat(sfs) implement snapshot policies data source#1445

Merged
cgoetz-inovex merged 12 commits into
mainfrom
feat/STACKITTPR-630_snapshot-policy-list-resource
May 13, 2026
Merged

feat(sfs) implement snapshot policies data source#1445
cgoetz-inovex merged 12 commits into
mainfrom
feat/STACKITTPR-630_snapshot-policy-list-resource

Conversation

@cgoetz-inovex
Copy link
Copy Markdown
Contributor

Description

relates to #1234

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@cgoetz-inovex cgoetz-inovex requested a review from a team as a code owner May 6, 2026 14:23
@rubenhoenle
Copy link
Copy Markdown
Member

Nitpick regarding commit message

- feat(sfs) implement snapshot policies data source
+ feat(sfs): implement snapshot policies data source

Comment thread stackit/internal/services/sfs/snapshot-policy/list_resource.go Outdated
Comment thread stackit/internal/services/sfs/snapshot-policy/policies_datasource.go Outdated
@cgoetz-inovex cgoetz-inovex enabled auto-merge (squash) May 13, 2026 14:53
@cgoetz-inovex cgoetz-inovex merged commit 709b30b into main May 13, 2026
2 checks passed
@cgoetz-inovex cgoetz-inovex deleted the feat/STACKITTPR-630_snapshot-policy-list-resource branch May 13, 2026 14:56
@github-actions
Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit 1.24% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/snapshot-policy 27.27% (+27.27%) 🌟

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/snapshot-policy/policies_datasource.go 27.27% (+27.27%) 66 (+66) 18 (+18) 48 (+48) 🌟
github.com/stackitcloud/terraform-provider-stackit/stackit/provider.go 1.24% (ø) 161 2 159

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/sfs_acc_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/snapshot-policy/policies_datasource_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants