Repository navigation
feat: update nextjs-shadcn to Next 15.4 - #122
Closed
sheepsteak wants to merge 3 commits into
Closed
sheepsteak wants to merge 3 commits into
sheepsteak wants to merge 3 commits into
Conversation
|
|
sheepsteak
marked this pull request as draft
August 6, 2026 10:36
Member
Author
|
With default Trying 
|
sheepsteak
force-pushed
the
chris/update-nextjs-shadcn
branch
from
August 6, 2026 11:00
d50ec44 to
e5e406e
Compare
sheepsteak
changed the title
nextjs-shadcn to Next 16nextjs-shadcn to Next 15.4
Member
Author
|
Closing for now as updated to WebContainer are needed. |
b3hr4d
added a commit
to B3Pay/ic-reactor
that referenced
this pull request
Oct 4, 2026
The lead opened each example on StackBlitz at 2ebc9b0. Two failed: - vite-wallet (`npm test`): "Test Files no tests, Errors 14 errors", each "ReferenceError: Iterator is not defined" from `m-tree.js#cjs:75:32`. That is jsdom's lib/jsdom/living/helpers/dom-tree.js, whose line 75 is `class ChildrenIterator extends Iterator {` since jsdom 30.1.0. The WebContainer reports Node 22.22.3 but defines no global `Iterator`, and `^30.0.1` resolved to 30.1.2 there (the workspace lockfile holds 30.0.1, so CI never met it). vitest loads jsdom when a worker starts, before any setup file, so the fix is the version: jsdom 30.0.1, which has no reference to the global, pinned exactly in vite-wallet, next-ssr and icrc-ledger (whose jsdom test would fail the same way in StackBlitz's terminal). Each vitest.config.ts says why. - next-ssr (`npm run dev -- --webpack`): GET / answered 500, "Invariant: Expected workStore to be initialized", from Next's own createServerSearchParamsForServerPage. Next 16 keeps the request's store in AsyncLocalStorage, which StackBlitz says WebContainer does not implement (stackblitz/starters#122). A production build renders through the same store, so its start command is now `npm test`, and its docs page says StackBlitz runs the tests and cannot serve the app. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ON HOLD: we need to implement AsyncLocalStorage in WebContainer before we can upgrade from the current Next.js version we use.
Created a brand new Next.js/Shadcn project and copied across necessary files from existing
nextjs-shadcn.Latest version we can do for now is Next.js 15.4 due to later versions using
AsyncLocalStoragewhich is not implemented in WebContainer yet. See #122 (comment) for Next.16 errors.