i was debugging #300 and then i came to the conclusion that we might need contents write permission on the github app! which was not a good idea and was not even a solution!
we just reverted that access, so hopefully all good now!
but here i'm going to explain why we need certain permissions for the app!
Checks
So we can have this beautiful indicator:
Contents
We do not need writes on this! We just want to read a commit!
Pull Requests
We need to read and write comments! Write so you can have a comment, and Read so we do not duplicate.
Metadata
This is mandatory from github and I do not think we need it.
Commit Status
I do not think we need this since Checks already get the job done, let me try and see if we can remove it.
i was debugging #300 and then i came to the conclusion that we might need contents write permission on the github app! which was not a good idea and was not even a solution!
we just reverted that access, so hopefully all good now!
but here i'm going to explain why we need certain permissions for the app!
Checks
So we can have this beautiful indicator:
Contents
We do not need writes on this! We just want to read a commit!
Pull Requests
We need to read and write comments! Write so you can have a comment, and Read so we do not duplicate.
Metadata
This is mandatory from github and I do not think we need it.
Commit Status
I do not think we need this since Checks already get the job done, let me try and see if we can remove it.