refactor: extract dereference and validate steps into controller modules#783
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ed resources Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
siegfriedweber
requested changes
May 20, 2026
30-assert now includes args, imagePullPolicy, defaultMode, and all container specs for the three HDFS StatefulSets. 31-assert is refactored to diff ConfigMap data against external snapshot files using envsubst and yq normalisation, replacing the previous inline envOverrides checks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replaces variable-based comparison with pipe-to-file approach. Both sides are normalised via jq (collapsing trailing \n+ to \n) so YAML block scalar style differences (|, |+) don't cause false failures. Temp files use $NAMESPACE prefix for concurrent test safety. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
siegfriedweber
approved these changes
May 21, 2026
adwk67
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dereferenceandvalidate) from the monolithichdfs_controller.rsintocontroller/dereference.rsandcontroller/validate.rshdfs_opa_config) intoValidatedCluster, matching the pattern established in hive (#707) and hbase (#757)image_base_name/pkg_versionparameters with compile-time constants insidevalidate_cluster()Test plan
cargo clippy --all-targets— zero warningscargo test— all 63 tests pass🤖 Generated with Claude Code