fix: durable clock race + dir fsync, cluster backoff/restart bounds, transport+wasm hardening#149
Merged
Merged
Conversation
…actor replay error, drop inert WithRetainTail Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
…upervisor.Forget, cover migration error paths Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
…dd README and client error-path tests Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
…ompile options, honest allocator docs Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this change does
Remediates the durable / cluster / transport / wasm review findings (correctness + perf + docs; no feature behavior change):
FileStore.writeAtomicfsyncs the parent directory after rename to honor the crash-durability claim;replayActorDatasurfaces a decode error instead of swallowing it; the inertWithRetainTailoption is removed (superseded byWithHistory).backoffDelayclamps before thetime.Durationconversion (no overflow atmaxDelay==0);Tickguards a nil respawner; addedSupervisor.Forget(actorID)to bound therestartsmap (additive, chosen over eviction so the restart-storm budget is preserved); migration error-path tests added;Capturedocuments its non-atomic boundary.init()codec registration (both sides force the codec);StateAtwraps the wire error; added a README and client error-path tests.WithCloseOnContextDone(true)so a runaway guest is cancelled (with aloopguesttimeout test);len()-guarded the result-slice indexing that could panic the host; added a variadicCompileOption/WithRuntimeConfig(additive); README allocator note corrected.Skipped with reasoning: durable Dispatched-set caching (risks the exactly-once invariant against out-of-tree Stores) and tagging
cluster/integration_test.go(would drop an in-process test from the default run and break the coverage gate).Checklist
-race) + lint clean;e2egreen